Fix for Call to eval-like DOM function - #23
Draft
jf205 wants to merge 1 commit into
Draft
Conversation
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To fix this without changing intended functionality (displaying the current location), replace each
document.write(window.location)with a safe text-rendering approach that does not parse HTML/script.Best approach in this file: use
document.body.appendChild(document.createTextNode(String(window.location)));.This preserves output of the location value while ensuring it is inserted as plain text, not executable markup.
File/region to change:
foo.js, all lines wheredocument.write(window.location);appears (including line 147 and the repeated instances shown).No new imports, helper methods, or dependencies are needed.
Suggested fixes powered by Copilot Autofix. Review carefully before merging.